[Tin Jingyao] iP #507

tin-jy · 2022-08-29T14:28:30Z

DukePro

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use
All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

There are 3 types of tasks, Todos, Events, and Deadline tasks

edricyeo

Generally good effort!
I like the clear naming of classes, variables and methods.
I think generally you could split your code into different classes, and include JavaDocs for your classes and methods!

edricyeo · 2022-08-31T07:18:14Z

src/main/java/Duke.java

+import java.util.ArrayList;
+import java.util.Locale;
+import java.util.Scanner;
+
 public class Duke {


Perhaps apply OOP to split the Duke class into different smaller classes?

edricyeo · 2022-08-31T07:20:49Z

src/main/java/Duke.java

+
+ private static final ArrayList<Task> LIST_OF_THINGS = new ArrayList<>();
+
+ private abstract static class Task {


Maybe you could create Task as a separate class, instead of nesting it in the Duke class.

edricyeo · 2022-08-31T07:22:17Z

src/main/java/Duke.java

+ }
+ }
+
+ private static class EventTask extends Task {


I like how you named the different Tasks clearly! 👍

edricyeo · 2022-08-31T07:31:28Z

src/main/java/Duke.java

+ return false;
+ }
+ try {
+ Integer.parseInt(str.substring(7));


Perhaps you could consider using str.split(" ") rather than str.substring(7). May improve reusability of code instead of having to change the number according to the length of the command?

edricyeo · 2022-08-31T07:39:51Z

src/main/java/Duke.java

 public class Duke {
+
+ private static final ArrayList<Task> LIST_OF_THINGS = new ArrayList<>();


Maybe you could consider extracting this out as a separate TaskList class, which would handle adding tasks, etc.

domoberzin

Coding standard is generally adhered to w.r.t naming, but could extract out the different classes, as well as add JavaDocs. :)

domoberzin · 2022-09-01T07:34:01Z

src/main/java/Duke.java

+import java.util.ArrayList;
+import java.util.Locale;
+import java.util.Scanner;
+
 public class Duke {


Could split the class into various classes, i.e. TaskList, Event, Deadline, instead of putting them into one class

domoberzin · 2022-09-01T07:34:42Z

src/main/java/Duke.java

+ private static final ArrayList<Task> LIST_OF_THINGS = new ArrayList<>();
+
+ private abstract static class Task {
+ private final String task_name;


Should be camelcase formatting for variables

domoberzin · 2022-09-01T07:35:31Z

src/main/java/Duke.java

+import java.util.ArrayList;
+import java.util.Locale;
+import java.util.Scanner;
+
 public class Duke {


Could also add JavaDocs for documentation purposes

Shifted inner class Task to a new file

DarrenCsAcc · 2022-09-04T06:36:43Z

src/main/java/duke/Command.java

+public class Command {
+
+}


I am curious why is this empty?

…2223S1/ip

# Conflicts: # src/main/java/duke/Duke.java # src/main/java/duke/task/TodoTask.java

# Conflicts: # src/main/java/duke/Parser.java

# Conflicts: # text-ui-test/EXPECTED.TXT # text-ui-test/input.txt

Let's shorten excessively long methods by abstracting out certain parts into separate methods.

Add assert statements

# Conflicts: # src/main/java/duke/Parser.java

Branch a-code-quality

Flexibility to change the local file path through Duke allows users to set new file locations without restarting Duke. Users may also create new files this way.

Add some JavaDocs

damithc and others added 8 commits July 31, 2022 17:20

Add Gradle support

556af3f

Add ability to read inputs and echo it as output

1541204

Add add and list functionality

18f1898

Add functionality to mark and unmark tasks

ec9fd31

Add different types of tasks

400cf62

There are 3 types of tasks, Todos, Events, and Deadline tasks

Add test cases for text-ui testing

7bc53d7

Add error handling for incorrect user inputs

6f5be36

Add functionality to remove tasks

ddb1d97

edricyeo reviewed Aug 31, 2022

View reviewed changes

domoberzin reviewed Sep 1, 2022

View reviewed changes

tin-jy added 6 commits September 1, 2022 21:19

Add a FileHandler class to deal with saving inputs in a local file

841c78b

Shifted inner class Task to a new file

Add functionality to save task list into a local file on every change

129758c

Add functionality for Duke to load task list on startup

c351d1d

Add ability for Duke to verify dates and time

a69c99c

Add classes Parser, Ui, TaskList to include more OOP

462fb51

Place all Duke related Java files into packages

4d4f45d

DarrenCsAcc reviewed Sep 4, 2022

View reviewed changes

src/main/java/duke/Command.java Outdated

Comment on lines 3 to 5

public class Command {

}

Copy link

DarrenCsAcc Sep 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious why is this empty?

tin-jy added 13 commits September 6, 2022 23:18

Merge branch 'add-gradle-support' of https://github.com/nus-cs2103-AY…

fbdbd16

…2223S1/ip

Add more packages and classes for organisation

304acb1

Add more classes and error handling

609dc79

Add JUnit tests for public methods in some classes

fe3f213

Update dependencies in build.gradle

86fba2c

Add JavaDocs

982ba6d

Correct style issues to adhere to coding standards

7338f37

Add ability to search for tasks using keywords

aef9014

Merge branch 'branch-A-CodingStandard'

8009da8

# Conflicts: # src/main/java/duke/Duke.java # src/main/java/duke/task/TodoTask.java

Merge branch 'branch-Level-9'

b99000a

# Conflicts: # src/main/java/duke/Parser.java

Add checkstyle.xml and suppressions.xml for checkstyle

3bda679

Fix a bug with the find command

a2c8035

Add test cases

6741565

tin-jy and others added 18 commits September 7, 2022 22:01

Create JAR file

ce8111d

Add a basic GUI for Duke

217e318

Fully implement GUI and allow Duke to respond to commands

7554d3d

Merge branch 'branch-A-CheckStyle'

cfabe0d

# Conflicts: # text-ui-test/EXPECTED.TXT # text-ui-test/input.txt

Add package for GUI related java files

5d7b0ab

Add more JUnit tests

1297ade

Add assert statements

ddf41bb

Improve code quality

dafecc7

Let's shorten excessively long methods by abstracting out certain parts into separate methods.

Merge pull request #1 from tin-jy/branch-A-Assertions

14da0b9

Add assert statements

Merge branch 'master' into branch-A-CodeQuality

4cd2cf6

# Conflicts: # src/main/java/duke/Parser.java

Merge pull request #2 from tin-jy/branch-A-CodeQuality

3c0576a

Branch a-code-quality

Add functionality to change the file path for local storage

7f02321

Flexibility to change the local file path through Duke allows users to set new file locations without restarting Duke. Users may also create new files this way.

Change some output messages

a883516

Add some bugfixes

3574c8a

Add some JavaDocs

Fix checkstyle issues

c8e2fdc

Change profile images for Duke and the user.

0d08193

Add a user guide in README.md

a2eb1a6

Fix bug related to local file path

b8d38f9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tin Jingyao] iP #507

[Tin Jingyao] iP #507

tin-jy commented Aug 29, 2022 •

edited

Loading

edricyeo left a comment

edricyeo Aug 31, 2022

edricyeo Aug 31, 2022

edricyeo Aug 31, 2022

edricyeo Aug 31, 2022

edricyeo Aug 31, 2022

domoberzin left a comment

domoberzin Sep 1, 2022

domoberzin Sep 1, 2022

domoberzin Sep 1, 2022

DarrenCsAcc Sep 4, 2022


		private static final ArrayList<Task> LIST_OF_THINGS = new ArrayList<>();

		private abstract static class Task {

		public class Duke {

		private static final ArrayList<Task> LIST_OF_THINGS = new ArrayList<>();

[Tin Jingyao] iP #507

Are you sure you want to change the base?

[Tin Jingyao] iP #507

Conversation

tin-jy commented Aug 29, 2022 • edited Loading

DukePro

edricyeo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

domoberzin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tin-jy commented Aug 29, 2022 •

edited

Loading