updated the note for "insert" so that it points to the explanation of why ...0... and ...[0]... are wildly different. #25895 #26114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… why ...0... and ...[0]... are wildly different. numpy#25895
Chillthrower
changed the title
jud-sdev
reviewed
May 24, 2024
Comment on lines
+5556
to
+5558
| ``arr[:,[0],:] = values``. This is due to the way NumPy handles broadcasting and | ||
| axis manipulation. For a detailed explanation, refer to the documentation on | ||
| [Broadcasting](https://numpy.org/doc/stable/user/basics.broadcasting.html). |
There was a problem hiding this comment.
Suggested change
| ``arr[:,[0],:] = values``. This is due to the way NumPy handles broadcasting and | |
| axis manipulation. For a detailed explanation, refer to the documentation on | |
| [Broadcasting](https://numpy.org/doc/stable/user/basics.broadcasting.html). | |
| ``arr[:,[0],:] = values``. This is due to the way NumPy handles | |
| :ref:`broadcasting <basics.broadcasting>` and axis manipulation. |
Thank you for contributing to Numpy. I noticed the line length was too long and I updated your example to use the internal link structure.
|
I don' think pointing users to the broadcasting document is the right way to help them here. If anything, it should be the indexing documentation, but there should be a further explanation of why the indexing makes the results change. I will close this, please open a new PR if you are interested in pursuing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the note for "insert" so that it points to the explanation of why ...0... and ...[0]... are wildly different. #25895