Enable inlining of first-class function when it is statically known to be a dispatcher #9077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to remove noinline in the cfunc wrapper.
sklam
commented
Jul 19, 2023
numba/core/cpu.py
Outdated
| @@ -205,7 +205,7 @@ def create_cfunc_wrapper(self, library, fndesc, env, call_helper): | |||
|
|
|||
| status, out = self.call_conv.call_function( | |||
| builder, wrapper_callee, fndesc.restype, fndesc.argtypes, | |||
| wrapfn.args, attrs=('noinline',)) | |||
| wrapfn.args) | |||
There was a problem hiding this comment.
After discussion with @stuartarchibald, this will need to be undone or it will leads to many optimization issues.
The alternative is to make first-class function use the Numba function without the wrapper when possible.
There was a problem hiding this comment.
Yeah, I think so. making it always inline could lead to many issues. One potential drawback could increase the compilation time, if the body of FunctionType is huge. Or maybe it's a bug in inline-related passes...
|
This pull request is marked as stale as it has had no activity in the past 3 months. Please respond to this comment if you're still interested in working on this. Many thanks! |
github-actions
bot
added
the
abandoned - stale
github-actions
bot
removed
abandoned - stale
…tion in typedobjectutils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.jit_addrto store the numba-internal function address that follows the numba callconv..jit_addrcan raise exception.TODO:
[ ]FunctionTypecalled by another jitted function throws aValueError#9206 (comment) Avoid the cfunc wrapper would be good..jit_addrin the FunctionType struct).