Feature/galactic noise adder upgrade channel dts #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included various sky models, moved sky noise generation out of run and into begin procedure
The channels have different positions, so there is a phase difference in the signals between the channels, which is now taken into account.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the galactic noise adder generated random galactic noise for each channel. This PR expands the selection of available galactic sky models (thanks @karenterveer) and uses consistent galactic noise between all channels (thanks @MoritzReichert), taking into account the phase differences due to the different antenna positions.
TODO:
try:... except ImportError:...clauses