move black & flake8 to precommit
#739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 17 17
Lines 1633 1633
=======================================
Hits 1494 1494
Misses 139 139 Continue to review full report in Codecov by Sentry.
|
willingc
approved these changes
Nov 13, 2023
Could you pls install the precommit bot and set it as required check so we preserve the code quality bar... 馃惏 Probably it need to be someone with org admin 馃Ι |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It shall simplify maintenance since we already have the preco-commit configuration with installing this precommit bot (free for public repos); it will eventually apply fixes for incorrect formatting so the user doe/contributor does not need to think about it... I have been using it on several other projects and it is very helpful without any overhead... 馃惏
Also, after adding the bot requited check will need to be updated