[WIP] Refactor language logic into a new mythic package #5616
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Wouldn't be a Crystalline Cat PR without substantial feature creep so I present: Multi-Language Notebooks (very WIP!)
@captainsafia Any thoughts on UI/UX? |
This comment has been minimized.
This comment has been minimized.
|
@CrystallineCat Could we have the language setting as an item in the cell dropdown list? It's not the most discoverable but it would be a good place to park the feature while we test. Loving the feature creep! 😃 |
This comment has been minimized.
This comment has been minimized.
CrystallineCat
changed the title
CrystallineCat
force-pushed
the
mags/mythic-language-info
branch
from
30324b2
to
ce7e3c5
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CrystallineCat
force-pushed
the
mags/mythic-language-info
branch
from
ce7e3c5
to
31b663e
Compare
CrystallineCat
force-pushed
the
mags/mythic-language-info
branch
from
31b663e
to
65ca6e9
Compare
|
This pull request introduces 1 alert when merging 65ca6e9 into 2e32ffa - view on LGTM.com new alerts:
|
|
Just a heads up, you can review notebook changes like this using GitNotebooks. e.g. this pull request https://gitnotebooks.com/nteract/nteract/pull/5616 It allows inline comments on code and markdown, and it's free for public repos so I thought I'd share.. |
Fixes #5482.
Factors out the language selection logic from the editor components into a mythic package. Uses data from https://github.com/github/linguist to aid in language mapping to editor modes.