Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to include the repository #5614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

v-rr
Copy link

@v-rr v-rr commented Oct 25, 2021

Hi there!
This change adds the repository property to your package.json file(s). Having this available provides a number of benefits to security tooling. For example, it allows for greater trust by checking for signed commits, contributors to a release and validating history with the project. It also allows for comparison between the source code and the published artifact in order to detect attacks on authors during the publication process.
We validate that we're making a PR against the correct repository by comparing the metadata for the published artifact on npmjs.com against the metadata in the package.json file in the repository.
This change is provided by a team at Microsoft -- we're happy to answer any questions you may have. (Members of this team include @s-tuli, @iarna, @rancyr, @Jaydon Peng, @Zhongpeng Zhou and @Jingying Gu). If you would prefer that we not make these sorts of PRs to projects you maintain, please just say. If you'd like to learn more about what we're doing here, we've prepared a document talking about both this project and some of our other activities around supply chain security here: microsoft/Secure-Supply-Chain
This PR provides repository metadata for the following packages:

  • @nteract/webpack-configurator
  • @nteract/types
  • @nteract/styles
  • @nteract/selectors
  • @nteract/reducers
  • @nteract/presentational-components
  • @nteract/notebook-app-component
  • @nteract/myths
  • @nteract/mythic-windowing
  • @nteract/mythic-notifications
  • @nteract/mythic-multiselect
  • @nteract/mythic-configuration
  • @nteract/monaco-editor
  • @nteract/messaging
  • @nteract/fixtures
  • @nteract/editor
  • @nteract/core
  • @nteract/connected-components
  • @nteract/commutable
  • @nteract/actions
  • @mybinder/host-cache

…dds the repository property to your package.json file(s). Having this available provides a number of benefits to security tooling. For example, it allows for greater trust by checking for signed commits, contributors to a release and validating history with the project. It also allows for comparison between the source code and the published artifact in order to detect attacks on authors during the publication process. We validate that we're making a PR against the correct repository by comparing the metadata for the published artifact on [npmjs.com](www.npmjs.com) against the metadata in the package.json file in the repository. This change is provided by a team at Microsoft -- we're happy to answer any questions you may have. (Members of this team include [@s-tuli](https://github.com/s-tuli), [@iarna](https://github.com/iarna), [@rancyr](https://github.com/v-rr), [@jaydon Peng](https://github.com/v-jiepeng), [@zhongpeng Zhou](https://github.com/v-zhzhou) and [@jingying Gu](https://github.com/v-gjy)). If you would prefer that we not make these sorts of PRs to projects you maintain, please just say. If you'd like to learn more about what we're doing here, we've prepared a document talking about both this project and some of our other activities around supply chain security here: [microsoft/Secure-Supply-Chain](https://github.com/microsoft/Secure-Supply-Chain) This PR provides repository metadata for the following packages: * @nteract/webpack-configurator * @nteract/types * @nteract/styles * @nteract/selectors * @nteract/reducers * @nteract/presentational-components * @nteract/notebook-app-component * @nteract/myths * @nteract/mythic-windowing * @nteract/mythic-notifications * @nteract/mythic-multiselect * @nteract/mythic-configuration * @nteract/monaco-editor * @nteract/messaging * @nteract/fixtures * @nteract/editor * @nteract/core * @nteract/connected-components * @nteract/commutable * @nteract/actions * @mybinder/host-cache
@vercel
Copy link

vercel bot commented Oct 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nteract/site/HVz2jsfiaa4CzPZdjRHTFaZyrSeg
✅ Preview: https://site-git-fork-v-rr-patch-1-nteract.vercel.app

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG other than the commit message needing to be updated to follow the conventional commit standard?

@v-rr
Copy link
Author

v-rr commented Jan 10, 2022

Is there anything that is needed to land this pull request ?

@v-rr
Copy link
Author

v-rr commented Feb 24, 2022

ls there anything else I can do to land this pull request?

@captainsafia
Copy link
Member

@v-rr The commit in this PR needs to be updated to follow the conventional commit standard per the detail below.

#5614 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants