Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build hydrogen using parcel #2116

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: build hydrogen using parcel #2116

wants to merge 5 commits into from

Conversation

aminya
Copy link
Member

@aminya aminya commented Jun 1, 2021

TODO: remote kernel doesn't work

@aminya aminya force-pushed the parcel branch 11 times, most recently from 59bac8e to 1a06e8a Compare June 2, 2021 05:32
@aminya aminya marked this pull request as ready for review June 2, 2021 05:32
@aminya aminya added the ci label Jun 2, 2021
@aminya aminya force-pushed the parcel branch 4 times, most recently from df96baa to 70a17bf Compare June 2, 2021 06:47
@todo
Copy link

todo bot commented Jun 2, 2021

use @aminya/xmlhttprequest

const { XMLHttpRequest } = require("xmlhttprequest"); // TODO use @aminya/xmlhttprequest
const request = new XMLHttpRequest();
// Disable protections against setting the Cookie header
request.setDisableHeaderCheck(true);
return request as XMLHttpRequest; // TODO fix the types


This comment was generated by todo based on a TODO comment in e1bbb7e in #2116. cc @nteract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant