Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): update regex for remote URL #23186

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

pcopley
Copy link

@pcopley pcopley commented May 4, 2024

Updates remote URL regex to match on GitHub, GitHub Enterprise, and local git repositories.

Current Behavior

Currently the regular expression will only match URLs beginning with github.com

Expected Behavior

It should also match GitHub Enterprise as well as local git repositories

Related Issue(s)

Fixes #23178
Closes #21906

Updates remote URL regex to match on GitHub, GitHub Enterprise, and local git repositories.

Closes nrwl#23178
Closes nrwl#21906
@pcopley pcopley requested a review from a team as a code owner May 4, 2024 13:14
@pcopley pcopley requested a review from Cammisuli May 4, 2024 13:14
Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 4, 2024 1:16pm

Copy link

nx-cloud bot commented May 4, 2024

@pcopley pcopley marked this pull request as draft May 4, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx release only supports GitHub URLs nx release changelog should support non github.com remotes
2 participants