feat(core): add an option to seperate the output of show with provide…

[dasco144]

…d character

npx nx show projects --affected --type=app --sep "," will output the affected projects with a "," separating each project output

closed #22219

Current Behavior

There is no way to change the separator used, the output of npx nx show projects will list all the projects in the workspace separated by a newline character.

Expected Behavior

providing a string for the "sep" arg will output the projects separated by the provided string

e.g. npx nx show projects --sep "," with projects, foo, bar and baz in the workspace, will output foo,bar,baz

Related Issue(s)

Fixes #22219

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	May 6, 2024 4:04pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f843fb8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=e2e,e2e-ci --base=f73d6530a159ecb5a8bafdf6120ce0415bfb33ef --head=f843fb88143d02688cdac4af2e733c91a1576f22 --parallel=1
• nx affected --targets=lint,test,build --base=f73d6530a159ecb5a8bafdf6120ce0415bfb33ef --head=f843fb88143d02688cdac4af2e733c91a1576f22 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=f73d6530a159ecb5a8bafdf6120ce0415bfb33ef --head=f843fb88143d02688cdac4af2e733c91a1576f22
• nx documentation --no-dte
• nx affected -t e2e-macos-ci --parallel=1 --base=f73d6530a159ecb5a8bafdf6120ce0415bfb33ef --head=f843fb88143d02688cdac4af2e733c91a1576f22

---

Sent with 💌 from NxCloud.

[AgentEnder]

Looked mostly good, I went ahead and pushed up the changes I was planning to request.

The biggest thing to keep in mind for future contributions would be that the unit tests you included that used the tree didn't work as intended. They were "passing" because the end of the show projects handler had a process.exit(0) call which shutdown the tests with exit code 0. In actuality, the intended projects didn't exist in the graph found by the show projects handler.

The Tree instance only works with generators, and doesn't affect createProjectGraphAsync. You really have to mock it out, otherwise it ends up creating the graph for whatever the repo that the current project root is in.

In this case, you can see the changed approach in projects.spec.ts

[dasco144]

Thanks @AgentEnder, appreciate the feedback 🙏

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.