fix(module-federation): Throw an error if remote is invalid #23100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndcunningham
added
scope: react
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4571f5d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
approved these changes
Apr 30, 2024
ndcunningham
force-pushed
the
fix/module-federation-remote-name-invalid
branch
3 times, most recently
from
2a9fbbd
to
262d90c
Compare
ndcunningham
requested review from
meeroslav,
vsavkin,
mandarini and
a team
as code owners
ndcunningham
force-pushed
the
fix/module-federation-remote-name-invalid
branch
5 times, most recently
from
35f0439
to
aae6275
Compare
ndcunningham
force-pushed
the
fix/module-federation-remote-name-invalid
branch
from
aae6275
to
4571f5d
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
May 13, 2024
If you are generating a remote using `--dynamic` either by using the `host` generator or the `remote` generator we now check to ensure that the remote name is a valid JavaScript variable. If this is not done the app with be invalid and unable to be ran or bundled. closes: #23024 (cherry picked from commit 0322b98)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are generating a remote using
--dynamiceither by using thehostgenerator or theremotegenerator we now check to ensure that the remote name is a valid JavaScript variable.If this is not done the app with be invalid and unable to be ran or bundled.
closes: #23024