fix(bundling): resolve index files from ts paths when running esbuild without bundling #23098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without bundling Replace isFile implementation to use Node require.resolve to handle cases when name of file (index) is ommited in code
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4ad0a28. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
Just found that this issue already has a PR #22054 - but with a different approach and still in draft, maybe we can close it once this once is merged (or that one) |
Coly010
approved these changes
May 8, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 9, 2024
… without bundling (#23098) ## Current Behavior During build process a file `tmp/<path>/main-with-require-overrides.js` is generated to handle `paths` resolutions from `tsconfig` when `esbuild` is not running in `bundle` mode. Having following `tsconfig.json` as example ```json { ... "compilerOptions": { ... "paths": { "@lib/lib1": ["libs/lib1/src/index.ts"], "@app1/*": ["apps/app1/src/*"], } } } ``` We can use `lib1` in code as follows and during runtime it will automatically be resolved to `dist/apps/app1/libs/lib1/src/index.js`: ```js // apps/app1/src/main.ts import lib1 from '@lib/lib1'; ``` Hovewer, when trying to use paths with wildcards, e.g.: ```js // apps/app1/src/config/index.ts const config = {}; export default config; // apps/app1/src/main.ts import config from '@app1/config'; ``` It gets resolved to `dist/apps/app1/apps/app1/src/config.js` and `isFile` condition fails as such module doesn't exist, thus path is not replaced and runtime error is produced. ## Expected Behavior During resolution of following code: ```js import config from '@app1/config'; ``` `_resolveFilename` should consider all possible combinations of module path - `dist/apps/app1/apps/app1/src/config.js` and `dist/apps/app1/apps/app1/src/config/index.js` (cherry picked from commit 46336df)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
During build process a file
tmp/<path>/main-with-require-overrides.jsis generated to handlepathsresolutions fromtsconfigwhenesbuildis not running inbundlemode.Having following
tsconfig.jsonas example{ ... "compilerOptions": { ... "paths": { "@lib/lib1": ["libs/lib1/src/index.ts"], "@app1/*": ["apps/app1/src/*"], } } }We can use
lib1in code as follows and during runtime it will automatically be resolved todist/apps/app1/libs/lib1/src/index.js:Hovewer, when trying to use paths with wildcards, e.g.:
It gets resolved to
dist/apps/app1/apps/app1/src/config.jsandisFilecondition fails as such module doesn't exist, thus path is not replaced and runtime error is produced.Expected Behavior
During resolution of following code:
_resolveFilenameshould consider all possible combinations of module path -dist/apps/app1/apps/app1/src/config.jsanddist/apps/app1/apps/app1/src/config/index.js