cleanup(angular): use module & moduleResolution node16 #23093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 01090a1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
angular/node-16
branch
2 times, most recently
from
f32ea6b
to
d2448c8
Compare
leosvelperez
force-pushed
the
angular/node-16
branch
from
d2448c8
to
01090a1
Compare
|
I'm going to close this and include the changes in the Angular v18 branch so they make more sense and are tested in the context where they are actually required. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the TypeScript configuration for the
@nx/angularplugin to usemoduleandmoduleResolutionset tonode16. The upcoming Angular v18 support needs this, but we can do it ahead of time to keep the Angular 18 PR leaner.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #