New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vitest with Project Crystal does not work with watch flag #23185
Labels
Comments
FrozenPandaz
added
the
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
label
May 9, 2024
Coly010
added a commit
that referenced
this issue
May 10, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> We currently do not handle passing `--watch` when running inferred `vitest` commands ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> We should support handling `--watch` ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23185
FrozenPandaz
pushed a commit
that referenced
this issue
May 13, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> We currently do not handle passing `--watch` when running inferred `vitest` commands ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> We should support handling `--watch` ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23185 (cherry picked from commit 7cf09a6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Current Behavior
When Project Crystal is used with vitest, the command that vitest generates uses
vitest run
which prevents entering watch mode.Expected Behavior
Watch mode should work when passed on the command line.
GitHub Repo
No response
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
10.5.2
Operating System
Additional Information
Issue appears to be here:
nx/packages/vite/src/plugins/plugin.ts
Line 212 in 7303b7a
Since this is using
run
, this implies--watch=false
and cannot be overridden.The text was updated successfully, but these errors were encountered: