Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .prettierignore and reformat repository #127

Merged
merged 6 commits into from
May 30, 2024

Conversation

henrik-dmg
Copy link
Contributor

Hi there, this is a simple one.

Changes

  • added .prettierignore files
  • ran prettier --write "**/*.{js,ts,jsx,tsx,md}" --config prettier.config.js --ignore-path .prettierignore and committed changes

Could be cool if we had a pre-commit hook for this for example :) or a Github Action that lints

Signed-off-by: Henrik Panhans <[email protected]>
Signed-off-by: Henrik Panhans <[email protected]>
Copy link

vercel bot commented Apr 4, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @nrjdalal on Vercel.

@nrjdalal first needs to authorize it.

@nrjdalal
Copy link
Owner

nrjdalal commented Apr 5, 2024

I would welcome this commit, just add husky for pre-commit use-case :) and add the script to package.json

@henrik-dmg
Copy link
Contributor Author

Awesome, I added the changes to this PR 🙂 I followed the steps here:

https://prettier.io/docs/en/precommit.html#option-1-lint-stagedhttpsgithubcomokonetlint-staged

@nrjdalal
Copy link
Owner

nrjdalal commented Apr 8, 2024

would check changes shortly during this week, thank you for contributing :D

@henrik-dmg
Copy link
Contributor Author

Any updates? 🙂

@nrjdalal
Copy link
Owner

need to see lint-staged as it is new to me, didn't get the time yet, sorry for that, will surely merge if lint staged works for me to in next 2-3 days

@nrjdalal nrjdalal merged commit 6b4f933 into nrjdalal:main May 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants