Fix progress bar persisting when following a redirect (hotwired#1168)

npezza93 · Feb 7, 2024 · b815594 · b815594
1 parent aef1abd
commit b815594
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/core/drive/visit.js b/src/core/drive/visit.js
@@ -136,11 +136,11 @@ export class Visit {
  complete() {
  if (this.state == VisitState.started) {
  this.recordTimingMetric(TimingMetric.visitEnd)
+ this.adapter.visitCompleted(this)
  this.state = VisitState.completed
  this.followRedirect()
 
  if (!this.followedRedirect) {
- this.adapter.visitCompleted(this)
  this.delegate.visitCompleted(this)
  }
  }

diff --git a/src/tests/functional/navigation_tests.js b/src/tests/functional/navigation_tests.js
@@ -379,6 +379,7 @@ test("following a redirection", async ({ page }) => {
  await nextBody(page)
  assert.equal(pathname(page.url()), "/src/tests/fixtures/one.html")
  assert.equal(await visitAction(page), "replace")
+ await waitUntilNoSelector(page, ".turbo-progress-bar")
 })
 
 test("clicking the back button after redirection", async ({ page }) => {