Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routing analysis wip - support config object input #604

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Routing analysis wip - support config object input #604

merged 5 commits into from
Jun 19, 2024

Conversation

adisos
Copy link
Collaborator

@adisos adisos commented Jun 3, 2024

  • add parsing and example with config object

@adisos adisos mentioned this pull request Jun 3, 2024
Merged
Base automatically changed from routing_analysis_wip_3 to main June 10, 2024 13:07
zivnevo
zivnevo requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@zivnevo zivnevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Please see some small comments

pkg/ibmvpc/routing_tables_analysis.go Outdated Show resolved Hide resolved
pkg/ibmvpc/routing_tables_analysis.go Show resolved Hide resolved
pkg/ibmvpc/vpc.go Outdated Show resolved Hide resolved
pkg/common/pair.go Outdated Show resolved Hide resolved
pkg/ibmvpc/parser.go Outdated Show resolved Hide resolved
pkg/ibmvpc/parser.go Outdated Show resolved Hide resolved
pkg/ibmvpc/parser.go Show resolved Hide resolved
pkg/ibmvpc/parser.go Outdated Show resolved Hide resolved
pkg/ibmvpc/parser.go Outdated Show resolved Hide resolved
pkg/ibmvpc/parser.go Outdated Show resolved Hide resolved
@adisos adisos marked this pull request as ready for review June 19, 2024 11:24
@adisos adisos mentioned this pull request Jun 19, 2024
Open
zivnevo
zivnevo requested changes Jun 19, 2024
View reviewed changes
pkg/ibmvpc/parser.go Show resolved Hide resolved
pkg/vpcmodel/multi_vpc_config.go Outdated Show resolved Hide resolved
@adisos
more updates
2d40d2e 
Signed-off-by: adisos <[email protected]>
zivnevo
zivnevo approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@zivnevo zivnevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the "wip" from the commit message 😄

@adisos adisos merged commit 4575b08 into main Jun 19, 2024
4 checks passed
@adisos adisos deleted the routing_analysis_wip_5 branch June 19, 2024 13:09
@adisos adisos mentioned this pull request Jun 20, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivnevo zivnevo zivnevo approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisos @zivnevo