Generic #597
Open
Generic #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Elazar Gershuni <[email protected]>
|
Updated to accommodate #634.
|
Signed-off-by: Elazar Gershuni <[email protected]>
|
Okay, now all the tests pass. The issue was the use of CartesianRightTriple instead of CartesianLeftTriple when partitioning TCPUDPSet. The decision is currently at the library side, but it should probably move to the client side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates the changes required in order to use the generic data structures (and ICMP set) in np-guard/models#33. 95% of the changes are renaming, but some are related to the introduction of a dedicated ICMP set.
Some tests still do not pass, due to an issue with tracking statefulness (which IMO should be part of this repo and not np-guard/models).
The line
replace github.com/np-guard/models => ../modelsin go.mod is useful for local experimentation until np-guard/models#33 is merged.