Skip to content

Commit

Permalink
added todo for #529
Browse files Browse the repository at this point in the history
  • Loading branch information
ShiriMoran committed May 26, 2024
1 parent d52ceb2 commit 67ed655
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkg/vpcmodel/explainabilityConnectivity.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ var filterLayers = [2]string{SecurityGroupLayer, NaclLayer}

const ResourceTypeIKSNode = "IKSNodeNetworkInterface"

// todo: https://github.com/np-guard/vpc-network-config-analyzer/issues/529 (after https://github.com/np-guard/vpc-network-config-analyzer/issues/255)
// todo srcDstDetails is either completely stateful or completely non-stateful
// todo keep stateful sg rules as part of current rulesConnection relevant properties (potentialAllowRules at el) or duplicate all relevant structs?

// rulesInLayers contains specific rules across all layers (SGLayer/NACLLayer)
// it maps from the layer name to the list of rules
type rulesInLayers map[string][]RulesInTable
Expand All @@ -33,6 +37,8 @@ type srcDstDetails struct {
src Node
dst Node
connEnabled bool
// todo for https://github.com/np-guard/vpc-network-config-analyzer/issues/255
stateful bool
// note that if dst/src is external then egressEnabled/ingressEnabled may be false and yet connEnabled true
ingressEnabled bool
egressEnabled bool
Expand Down

0 comments on commit 67ed655

Please sign in to comment.