expose to the cluster services pointed by Ingress #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziv Nevo <[email protected]>
Signed-off-by: Ziv Nevo <[email protected]>
Signed-off-by: Ziv Nevo <[email protected]>
adisos
approved these changes
Jun 1, 2023
|
|
||
| exposedServicesInNamespace, ok := servicesToExpose[routeObj.Namespace] | ||
| if !ok { | ||
| servicesToExpose[routeObj.Namespace] = map[string]bool{} |
There was a problem hiding this comment.
does it handle Ingress/Route resources without a namespace?
There was a problem hiding this comment.
I believe it does. For such resources Namespace field is "", which is a valid key in the map.
Thus, it will only expose listed services which also do not have Namespace.
The BookInfo example has such an Ingress resource, and a corresponding Service. It seems to be exposed properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
In this PR:
ExposeToCluster=trueresourceFinderno longer stores Route resources, nor will it store Ingress resources. Instead, it just stores in a dedicated data structure all the services it will have to expose later on. When scanning a Route resource or an Ingress resource, this data structure gets updated with the Services mentioned in the scanned resource.