fix: hidden message dropdown below notifications center header #5496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looks good! @LetItRock @BiswaViraj can you give another look and help with merging? |
BiswaViraj
requested changes
May 7, 2024
There was a problem hiding this comment.
Good work @racky7 🎉
Have added a small suggestion, then it should be fine to merge
...ter/src/components/notification-center/components/notification-item/NotificationListItem.tsx
Show resolved
Hide resolved
BiswaViraj
approved these changes
May 7, 2024
|
Thanks @racky7 for this fix 🎉 |
LetItRock
added a commit
that referenced
this pull request
May 7, 2024
antonjoel82
pushed a commit
that referenced
this pull request
May 9, 2024
* fix: render dropdown within portal * fix: added middlewares prop in menu --------- Co-authored-by: Biswajeet Das <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Fix - #5490
Screenshots
Before -
After -