Remove logging for health check #5481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m logging This commit updates the nestjs-pino package from version 3.4.0 to 4.0.0 and updates related packages accordingly. Path exclusions in logging have also been introduced, starting with the '/ignore-me-path'. Subsequent changes are made in the config framework to reflect these updates and exclusions.
Cliftonz
requested review from
LetItRock,
a team and
denis-kralj-novu
and removed request for
a team
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The current commit modifies the logging configuration exclusion path. It replaces '/ignore-me-path' with '*/health-check'. Now, GET requests to '*/health-check' will be excluded from logging.
scopsy
approved these changes
May 8, 2024
SokratisVidros
approved these changes
May 13, 2024
# Conflicts: # pnpm-lock.yaml
The dependencies in the pnpm-lock.yaml file were updated, some lines were removed while others were added. The 'overrides' packages and the 'importers' versions, among others, were notably updated. Some new eslint plugins were also added to the codebase.
# Conflicts: # pnpm-lock.yaml
SokratisVidros
added a commit
that referenced
this pull request
May 16, 2024
This reverts commit 0d0b5bc.
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2024
* Update nestjs-pino and related packages and exclude certain paths from logging This commit updates the nestjs-pino package from version 3.4.0 to 4.0.0 and updates related packages accordingly. Path exclusions in logging have also been introduced, starting with the '/ignore-me-path'. Subsequent changes are made in the config framework to reflect these updates and exclusions. * Update exclusion path in logging configuration The current commit modifies the logging configuration exclusion path. It replaces '/ignore-me-path' with '*/health-check'. Now, GET requests to '*/health-check' will be excluded from logging. * Update dependencies and restructure pnpm-lock.yaml The dependencies in the pnpm-lock.yaml file were updated, some lines were removed while others were added. The 'overrides' packages and the 'importers' versions, among others, were notably updated. Some new eslint plugins were also added to the codebase. * Remove pnpm-lock.yaml file * Add pnpm-lock.yaml file
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2024
This reverts commit 0d0b5bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is aimed at removing logging from our health-check endpoint.
This decision comes in light of our continuous efforts towards cost optimization and efficient resource utilization.
The health-check endpoint is frequently hit to ensure the system's healthiness, whether it's by internal services, load-balancers, or monitoring systems. Each of these hits generates a log entry, which, over time, amounts to a significant volume of logs. This volume leads to increased storage needs and consequently higher costs associated with log storage and management.
While these logs do provide information, they offer little to no actionable value since health-checks usually don't carry business-critical data. The routine nature of these requests and the rare probability of error occurrence make the logs from health-check endpoints low in value yet high in cost. Hence, by removing logging from the health-check endpoint, we are aiming to: