New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add backend proxy for segment #5474
Conversation
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not currently covered in this PR - do we need to address(/remove) the Segment Identify/Group call that happens too?
Group is not used by frontend and identify only sends user id so we should already know that as we can get the user id from the user session. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's 🚢 it
Should we feature flag this endpoint based on the presence of |
Not sure I understand your comment 💯 but there is a check in the analytics service for the |
@davidsoderberg I think he meant don't make the http request on the first place if ff is not present to avoid the network activity. |
So this should be it then :) |
Thanks, @davidsoderberg, for the clarification. My initial comment was about not registering the Analytics module at all unless both env vars are set. We might be able to abstract the env var check via a static |
No description provided.