Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier for downstream to modify settings #1428

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CendioOssman
Copy link
Member

Expose a simple and stable API to override default settings, and force settings that users shouldn't be able to change.

Fixes #1159.

Makes sure everything behaves the same way, even if there is no visible
UI for a settings.
Makes it easier to see how things are connected.
Expose a simple and stable API to override default settings, and force
settings that users shouldn't be able to change.
@CendioOssman CendioOssman added this to the v1.2.0 milestone Jun 26, 2020
Copy link
Member

@samhed samhed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@CendioOssman
Copy link
Member Author

I just realised this isn't going to work with use_require.js. So either that needs to be fixed somehow, or we have to wait until we can drop Internet Explorer and require module support.

Putting this on hold for now.

@CendioOssman CendioOssman modified the milestones: v1.2.0, Future Features Jun 29, 2020
@CendioOssman CendioOssman marked this pull request as draft June 29, 2020 12:11
@CendioOssman
Copy link
Member Author

So #1477 is now up, so we just need to wait for that.

@tculp
Copy link

tculp commented Apr 19, 2021

Bump because this would be very useful and #1477 is now merged

@CendioOssman
Copy link
Member Author

It's still on my todo, but I'm unsure when I'll have time to finish this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make it easier to customize default host, password, port in the url via code
3 participants