Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Use ImageBitmap when possible #1131

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[WIP] Use ImageBitmap when possible #1131

wants to merge 3 commits into from

Commits on Oct 23, 2020

  1. Better encapsulate image loading 

    The render queue doesn't need to know how to wait for images to
load.
    @CendioOssman
    CendioOssman committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    40f8d62 View commit details
    Browse the repository at this point in the history

  2. Use Uint8Array in Base64 decoding 

    Otherwise each element isn't considered a single byte. This breaks
conversion to other types, e.g. Blob.
    @CendioOssman
    CendioOssman committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    7a6d805 View commit details
    Browse the repository at this point in the history

  3. Use ImageBitmap when possible 

    These are much faster than Image object in some browsers, so prefer
them when possible.
    @CendioOssman
    CendioOssman committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    8804b91 View commit details
    Browse the repository at this point in the history