Support loading config from pyproject.toml #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
tomli was ported to stdlib tomllib, so it's preferable to use these implementations for clearer (and more standard/common style) compatibility across versions. In order to have the failthrough behavior be clear, with dispatch onto TOML support controlled via a bool, this is wrapped in a module which provides failover on import errors per the normal path to prefer tomllib where available. 'tomli' is not required by nose2, not even on lower python versions, to ensure that application testing which is sensitive to and dispatched over the presence/absence of a toml loader is supported. tox matrix config supports toml-enabled test invocation for the lower python versions.
This ensures that the tests work when run from the packaged source, as the pyproject.toml files used as test cases are included.
sirosen
force-pushed
the
support-pyproject.toml
branch
from
6cf86e6
to
3cb4d45
Compare
|
I finally made a few minutes to look into those CI failures. The cause was pretty simple: missing |
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work started in #596 -- thanks to @qequ for getting this started!
I've made some changes which I believe are important to nose2 supporting the full breadth of use cases, including test matrices which run tests with TOML parsers present and absent in lower python versions.
In general, I think
nose2should avoid addig dependencies outside of the stdlib, since it is a test runner.There's some room for healthy debate on this, but with the current course of
tomli->tomllib, I don't think it's necessary for TOML support to add a hard dependency or an extra.