Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: current code depends (at least) on torch >= 2.2 #394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muffgaga
Copy link
Contributor

When trying import norse in the latest RC of the EBRAINS Software Distribution (24.04-RC), I get:

ImportError: cannot import name 'register_pytree_node' from 'torch.utils._pytree' (/srv/main-spack-instance-2402/spack/var/spack/environments/experimental/.spack-env/view/lib/python3.8/site-packages/torch/utils/_pytree.py)

This seems to be caused by a wrong dependency statement in terms of torch.
The used function has only been introduced in torch 2.2.0.

Copy link
Member

@Jegp Jegp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition, @muffgaga!

Would you like a new release for this, so you can install it without having to pin the (pip) install to a branch?

@muffgaga
Copy link
Contributor Author

Thanks for the addition, @muffgaga!

Would you like a new release for this, so you can install it without having to pin the (pip) install to a branch?

In terms of the EBRAINS Software Distribution it's fine, I'll just update the spack dependencies (and add a comment that for v1.1.0 the project file is just slightly wrong ;) ).

→ I.e. no need to adjust your release schedule/roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants