NSFS | NC | Changes in nsfs_config_schema
Related to strictify
#7889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
strictify
onnsfs_config_schema
.nsfs_config_schema
:description
withdoc
.default
.NSFS_WHITELIST
which is typearray
additems
under it.definitions
innsfs_config_schema
and set theadditionalProperties
tonsfs_node_config_schema
.load_nsfs_nc_config
.Issues: Fixed #7874
strictify
onnsfs_config_schema
and handling the errors.GAPS:
NSFS_WHITELIST
is validated when the user passes the commandsudo node src/cmd/manage_nsfs whitelist --ips <list-og-ips>
usingverify_whitelist_ips
:noobaa-core/src/cmd/manage_nsfs.js
Lines 993 to 1000 in d1bf8c4
noobaa-core/src/api/common_api.js
Lines 1204 to 1208 in d1bf8c4
In other cases, for example
ENDPOINT_FORKS
to beminimum
0 andmaximum
64 and remove the suggestions from thedoc
part.Testing Instructions:
Unit Tests
npx jest test_nc_nsfs_config_schema_validation.test.js
Manual Tests
To see that the config is used when running the nsfs server.
hostname
in your terminal (this will be the<hostname-output>
in the next step).sudo vi /etc/noobaa.conf.d/config.json
In this example we added 2 opposite values ofALLOW_HTTP
sudo node src/cmd/nsfs --debug 5
my-mac
is an example of a hostname):