Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update link to loong64 toolchain #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

shipujin
Copy link
Member

update link to loong64 toolchain

@rvagg
Copy link
Member

rvagg commented Feb 19, 2024

is this going to cause compatibility headaches for anyone using this when it bumps across all release lines? should we be branching on release line for this upgrade or are you confident that all users of these binaries are going to be happy with this bump?

@shipujin
Copy link
Member Author

is this going to cause compatibility headaches for anyone using this when it bumps across all release lines?

After I verified the update toolchain in the local docker, the compilation and running were successful, Didn't seem to find anything unusual.

should we be branching on release line for this upgrade

Well, in that case, what do I need to do? Can you guide me, thanks

or are you confident that all users of these binaries are going to be happy with this bump?

It seems that the update of the toolchain, adding new features to LoongArch, is a good thing to update the toolchain.

Best regards

@rvagg
Copy link
Member

rvagg commented Feb 20, 2024

@shipujin what I'm asking is - are binaries produced with this toolchain going to be problematic for people who have assumptions based around the previous toolchain. A bit like the issues that people have with glibc linking. If this is simply a compiler upgrade and the product is going to be roughly the same, but maybe better, then that's fine, best not overcomplicate the build process. My concern is about incompatibilities and I'm looking to you for guidance on that, or maybe some research if you don't know the answer?

@shipujin
Copy link
Member Author

@shipujin what I'm asking is - are binaries produced with this toolchain going to be problematic for people who have assumptions based around the previous toolchain. A bit like the issues that people have with glibc linking. If this is simply a compiler upgrade and the product is going to be roughly the same, but maybe better, then that's fine, best not overcomplicate the build process. My concern is about incompatibilities and I'm looking to you for guidance on that, or maybe some research if you don't know the answer?

ok, I understand what you mean. I will investigate what functions have been updated in the toolchain upgrade and then discuss with you, thanks

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants