Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make sure pass the cli_options to worker #52827

Merged
merged 1 commit into from May 12, 2024
Merged

src: make sure pass the cli_options to worker #52827

merged 1 commit into from May 12, 2024
+37 −18

Conversation

theanarkh
Copy link
Contributor

@theanarkh theanarkh commented May 4, 2024 •
edited by aduh95

Fixes: #52825

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels May 4, 2024
@theanarkh theanarkh force-pushed the fix_worker_options branch 3 times, most recently from eda633c to 85a63f3 Compare May 4, 2024 06:49
@theanarkh theanarkh marked this pull request as draft May 4, 2024 18:49
@theanarkh theanarkh marked this pull request as ready for review May 4, 2024 21:26
@theanarkh theanarkh force-pushed the fix_worker_options branch 6 times, most recently from ae4f4b9 to 103e509 Compare May 4, 2024 22:25
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 11, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59123/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59137/

@aduh95 aduh95 merged commit aba4a00 into nodejs:main May 12, 2024
53 of 56 checks passed
@aduh95
Copy link
Contributor

aduh95 commented May 12, 2024

Landed in aba4a00

targos pushed a commit that referenced this pull request May 12, 2024
@theanarkh @targos
src: make sure pass the argv to worker threads
ace65a9 
PR-URL: #52827
Fixes: #52825
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request May 13, 2024
Merged
This was referenced May 15, 2024
Merged
Open
@aduh95 aduh95 added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v21.x PRs that should not land on the v21.x-staging branch and should not be released in v21.x. labels May 17, 2024
@aduh95
Copy link
Contributor

aduh95 commented May 17, 2024

There's an open PR to revert this: #53021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v21.x PRs that should not land on the v21.x-staging branch and should not be released in v21.x. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpu-prof doesn't propagate to workers when env is set
4 participants
@theanarkh @nodejs-github-bot @aduh95 @jasnell