tools: fix V8 update workflow #52822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
targos
reviewed
May 3, 2024
Co-authored-by: Michaël Zasso <[email protected]>
targos
approved these changes
May 3, 2024
aduh95
added
author ready
marco-ippolito
approved these changes
May 3, 2024
richardlau
added
the
commit-queue-squash
richardlau
approved these changes
May 3, 2024
jasnell
approved these changes
May 4, 2024
lpinca
approved these changes
May 4, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 38ef4e5 |
Ch3nYuY
pushed a commit
to Ch3nYuY/node
that referenced
this pull request
May 8, 2024
PR-URL: nodejs#52822 Fixes: nodejs#50497 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 8, 2024
PR-URL: #52822 Fixes: #50497 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC the workflow is currently failing when an update is available because
grep "V8 is up-to-date"returns a non-zero exit code. I tested locally, and can confirm it does fix the script.Fixes: #50497