Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix typo Unabled -> Unable #52820

Merged
merged 1 commit into from May 11, 2024
Merged

src: fix typo Unabled -> Unable #52820

merged 1 commit into from May 11, 2024

Conversation

SimonSiefke
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 3, 2024
@RedYetiDev
Copy link
Member

Thanks for the PR! Please update the commit message to behind with the subsystem being changed, in this case, src:

src: fix typo Unabled -> Unable

@RedYetiDev RedYetiDev added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Fast-track has been requested by @RedYetiDev. Please 👍 to approve.

@RedYetiDev
Copy link
Member

Fast-Tracking, as this a pretty simple change.

@RedYetiDev RedYetiDev removed the needs-ci PRs that need a full CI run. label May 4, 2024
@RedYetiDev
Copy link
Member

Removing needs-ci, as this is a simple text-based error change, and it's change won't affect any testing / building

@aduh95 aduh95 added needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 48 hours to land. labels May 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58948/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58953/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59086/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit 04fbd0d into nodejs:main May 11, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 04fbd0d

targos pushed a commit that referenced this pull request May 11, 2024
@SimonSiefke @targos
src: fix typo Unabled -> Unable
75004d3 
PR-URL: #52820
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request May 13, 2024
Merged
@SimonSiefke SimonSiefke deleted the patch-1 branch May 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@SimonSiefke @RedYetiDev @nodejs-github-bot @jasnell @lpinca @tniessen @richardlau @marco-ippolito @HarshithaKP @aduh95