v20.13.0 proposal

.eslintrc.js

@@ -19,6 +19,7 @@ const hacks = [
  'eslint-plugin-markdown',
  '@babel/eslint-parser',
  '@babel/plugin-syntax-import-attributes',
+ '@stylistic/eslint-plugin-js',
 ];
 Module._findPath = (request, paths, isMain) => {
  const r = ModuleFindPath(request, paths, isMain);
@@ -39,7 +40,7 @@ module.exports = {
  es2022: true,
  },
  extends: ['eslint:recommended', 'plugin:jsdoc/recommended'],
- plugins: ['jsdoc', 'markdown', 'node-core'],
+ plugins: ['jsdoc', 'markdown', 'node-core', '@stylistic/js'],
  parser: '@babel/eslint-parser',
  parserOptions: {
  babelOptions: {
@@ -133,11 +134,7 @@ module.exports = {
  // https://eslint.org/docs/rules/
  'accessor-pairs': 'error',
  'array-callback-return': 'error',
- 'arrow-parens': 'error',
- 'arrow-spacing': 'error',
  'block-scoped-var': 'error',
- 'block-spacing': 'error',
- 'brace-style': ['error', '1tbs', { allowSingleLine: true }],
  'capitalized-comments': ['error', 'always', {
  line: {
  // Ignore all lines that have less characters than 20 and all lines that
@@ -150,49 +147,17 @@ module.exports = {
  ignorePattern: '.*',
  },
  }],
- 'comma-dangle': ['error', 'always-multiline'],
- 'comma-spacing': 'error',
- 'comma-style': 'error',
- 'computed-property-spacing': 'error',
  'default-case-last': 'error',
- 'dot-location': ['error', 'property'],
  'dot-notation': 'error',
- 'eol-last': 'error',
  'eqeqeq': ['error', 'smart'],
- 'func-call-spacing': 'error',
  'func-name-matching': 'error',
  'func-style': ['error', 'declaration', { allowArrowFunctions: true }],
- 'indent': ['error', 2, {
- ArrayExpression: 'first',
- CallExpression: { arguments: 'first' },
- FunctionDeclaration: { parameters: 'first' },
- FunctionExpression: { parameters: 'first' },
- MemberExpression: 'off',
- ObjectExpression: 'first',
- SwitchCase: 1,
- }],
- 'key-spacing': 'error',
- 'keyword-spacing': 'error',
- 'linebreak-style': 'error',
- 'max-len': ['error', {
- code: 120,
- ignorePattern: '^// Flags:',
- ignoreRegExpLiterals: true,
- ignoreTemplateLiterals: true,
- ignoreUrls: true,
- tabWidth: 2,
- }],
- 'new-parens': 'error',
- 'no-confusing-arrow': 'error',
  'no-constant-condition': ['error', { checkLoops: false }],
  'no-constructor-return': 'error',
  'no-duplicate-imports': 'error',
  'no-else-return': 'error',
- 'no-extra-parens': ['error', 'functions'],
  'no-lonely-if': 'error',
  'no-mixed-requires': 'error',
- 'no-multi-spaces': ['error', { ignoreEOLComments: true }],
- 'no-multiple-empty-lines': ['error', { max: 2, maxEOF: 0, maxBOF: 0 }],
  'no-new-require': 'error',
  'no-path-concat': 'error',
  'no-proto': 'error',
@@ -257,10 +222,8 @@ module.exports = {
  },
  ],
  'no-self-compare': 'error',
- 'no-tabs': 'error',
  'no-template-curly-in-string': 'error',
  'no-throw-literal': 'error',
- 'no-trailing-spaces': 'error',
  'no-undef': ['error', { typeof: true }],
  'no-undef-init': 'error',
  'no-unused-expressions': ['error', { allowShortCircuit: true }],
@@ -276,39 +239,11 @@ module.exports = {
  'no-useless-return': 'error',
  'no-var': 'error',
  'no-void': 'error',
- 'no-whitespace-before-property': 'error',
- 'object-curly-newline': 'error',
- 'object-curly-spacing': ['error', 'always'],
  'one-var': ['error', { initialized: 'never' }],
- 'one-var-declaration-per-line': 'error',
- 'operator-linebreak': ['error', 'after'],
- 'padding-line-between-statements': [
- 'error',
- { blankLine: 'always', prev: 'function', next: 'function' },
- ],
  'prefer-const': ['error', { ignoreReadBeforeAssign: true }],
  'prefer-object-has-own': 'error',
- 'quotes': ['error', 'single', { avoidEscape: true }],
- 'quote-props': ['error', 'consistent'],
- 'rest-spread-spacing': 'error',
- 'semi': 'error',
- 'semi-spacing': 'error',
- 'space-before-blocks': ['error', 'always'],
- 'space-before-function-paren': ['error', {
- anonymous: 'never',
- named: 'never',
- asyncArrow: 'always',
- }],
- 'space-in-parens': 'error',
- 'space-infix-ops': 'error',
- 'space-unary-ops': 'error',
- 'spaced-comment': ['error', 'always', {
- 'block': { 'balanced': true },
- 'exceptions': ['-'],
- }],
  'strict': ['error', 'global'],
  'symbol-description': 'error',
- 'template-curly-spacing': 'error',
  'unicode-bom': 'error',
  'valid-typeof': ['error', { requireStringLiterals: true }],
 
@@ -327,6 +262,74 @@ module.exports = {
  'jsdoc/check-tag-names': 'off',
  'jsdoc/require-returns': 'off',
 
+ // Stylistic rules
+ '@stylistic/js/arrow-parens': 'error',
+ '@stylistic/js/arrow-spacing': 'error',
+ '@stylistic/js/block-spacing': 'error',
+ '@stylistic/js/brace-style': ['error', '1tbs', { allowSingleLine: true }],
+ '@stylistic/js/comma-dangle': ['error', 'always-multiline'],
+ '@stylistic/js/comma-spacing': 'error',
+ '@stylistic/js/comma-style': 'error',
+ '@stylistic/js/computed-property-spacing': 'error',
+ '@stylistic/js/dot-location': ['error', 'property'],
+ '@stylistic/js/eol-last': 'error',
+ '@stylistic/js/func-call-spacing': 'error',
+ '@stylistic/js/indent': ['error', 2, {
+ ArrayExpression: 'first',
+ CallExpression: { arguments: 'first' },
+ FunctionDeclaration: { parameters: 'first' },
+ FunctionExpression: { parameters: 'first' },
+ MemberExpression: 'off',
+ ObjectExpression: 'first',
+ SwitchCase: 1,
+ }],
+ '@stylistic/js/key-spacing': 'error',
+ '@stylistic/js/keyword-spacing': 'error',
+ '@stylistic/js/linebreak-style': 'error',
+ '@stylistic/js/max-len': ['error', {
+ code: 120,
+ ignorePattern: '^// Flags:',
+ ignoreRegExpLiterals: true,
+ ignoreTemplateLiterals: true,
+ ignoreUrls: true,
+ tabWidth: 2,
+ }],
+ '@stylistic/js/new-parens': 'error',
+ '@stylistic/js/no-confusing-arrow': 'error',
+ '@stylistic/js/no-extra-parens': ['error', 'functions'],
+ '@stylistic/js/no-multi-spaces': ['error', { ignoreEOLComments: true }],
+ '@stylistic/js/no-multiple-empty-lines': ['error', { max: 2, maxEOF: 0, maxBOF: 0 }],
+ '@stylistic/js/no-tabs': 'error',
+ '@stylistic/js/no-trailing-spaces': 'error',
+ '@stylistic/js/no-whitespace-before-property': 'error',
+ '@stylistic/js/object-curly-newline': 'error',
+ '@stylistic/js/object-curly-spacing': ['error', 'always'],
+ '@stylistic/js/one-var-declaration-per-line': 'error',
+ '@stylistic/js/operator-linebreak': ['error', 'after'],
+ '@stylistic/js/padding-line-between-statements': [
+ 'error',
+ { blankLine: 'always', prev: 'function', next: 'function' },
+ ],
+ '@stylistic/js/quotes': ['error', 'single', { avoidEscape: true }],
+ '@stylistic/js/quote-props': ['error', 'consistent'],
+ '@stylistic/js/rest-spread-spacing': 'error',
+ '@stylistic/js/semi': 'error',
+ '@stylistic/js/semi-spacing': 'error',
+ '@stylistic/js/space-before-blocks': ['error', 'always'],
+ '@stylistic/js/space-before-function-paren': ['error', {
+ anonymous: 'never',
+ named: 'never',
+ asyncArrow: 'always',
+ }],
+ '@stylistic/js/space-in-parens': 'error',
+ '@stylistic/js/space-infix-ops': 'error',
+ '@stylistic/js/space-unary-ops': 'error',
+ '@stylistic/js/spaced-comment': ['error', 'always', {
+ 'block': { 'balanced': true },
+ 'exceptions': ['-'],
+ }],
+ '@stylistic/js/template-curly-spacing': 'error',
+
  // Custom rules from eslint-plugin-node-core
  'node-core/no-unescaped-regexp-dot': 'error',
  'node-core/no-duplicate-requires': 'error',

.github/CODEOWNERS

@@ -96,7 +96,6 @@
 /doc/api/packages.md @nodejs/loaders
 /lib/internal/bootstrap/realm.js @nodejs/loaders
 /lib/internal/modules/* @nodejs/loaders
-/lib/internal/process/esm_loader.js @nodejs/loaders
 /lib/internal/process/execution.js @nodejs/loaders
 /lib/module.js @nodejs/loaders
 /src/module_wrap* @nodejs/loaders @nodejs/vm

.github/workflows/build-tarball.yml

@@ -28,7 +28,7 @@ concurrency:
  cancel-in-progress: true
 
 env:
- PYTHON_VERSION: '3.11'
+ PYTHON_VERSION: '3.12'
  FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -43,7 +43,7 @@ jobs:
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
+ uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Environment Information
@@ -69,13 +69,13 @@ jobs:
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
+ uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Environment Information
  run: npx envinfo
  - name: Download tarball
- uses: actions/download-artifact@87c55149d96e628cc2ef7e6fc2aab372015aec85 # v4.1.3
+ uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
  with:
  name: tarballs
  path: tarballs

.github/workflows/build-windows.yml

@@ -2,34 +2,28 @@ name: Build Windows
 
 on:
  pull_request:
- paths:
- - lib/**/*.js
- - Makefile
- - src/**/*.cc
- - src/**/*.h
- - tools/gyp/**
- - .github/workflows/build-windows.yml
+ paths-ignore:
+ - README.md
+ - .github/**
+ - '!.github/workflows/build-windows.yml'
  types: [opened, synchronize, reopened, ready_for_review]
  push:
  branches:
  - main
  - canary
  - v[0-9]+.x-staging
  - v[0-9]+.x
- paths:
- - lib/**/*.js
- - Makefile
- - src/**/*.cc
- - src/**/*.h
- - tools/gyp/**
- - .github/workflows/build-windows.yml
+ paths-ignore:
+ - README.md
+ - .github/**
+ - '!.github/workflows/build-windows.yml'
 
 concurrency:
  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
  cancel-in-progress: true
 
 env:
- PYTHON_VERSION: '3.11'
+ PYTHON_VERSION: '3.12'
  FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -48,7 +42,7 @@ jobs:
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
+ uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Install deps

.github/workflows/close-stale-feature-requests.yml

@@ -19,9 +19,11 @@ env:
 
  WARN_MESSAGE: >
  There has been no activity on this feature request for
- 5 months and it is unlikely to be implemented.
- It will be closed 6 months after the last non-automated comment.
-
+ 5 months. To help maintain relevant open issues, please
+ add the https://github.com/nodejs/node/labels/never-stale
+ label or close this issue if it should be closed. If not,
+ the issue will be automatically closed 6 months after the
+ last non-automated comment.
 
  For more information on how the project manages
  feature requests, please consult the

.github/workflows/coverage-linux-without-intl.yml

@@ -30,7 +30,7 @@ concurrency:
  cancel-in-progress: true
 
 env:
- PYTHON_VERSION: '3.11'
+ PYTHON_VERSION: '3.12'
  FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -45,7 +45,7 @@ jobs:
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
+ uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Environment Information
@@ -68,6 +68,7 @@ jobs:
  - name: Clean tmp
  run: rm -rf coverage/tmp && rm -rf out
  - name: Upload
- uses: codecov/codecov-action@54bcd8715eee62d40e33596ef5e8f0f48dbbccab # v4.1.0
+ uses: codecov/codecov-action@c16abc29c95fcf9174b58eb7e1abf4c866893bc8 # v4.1.1
  with:
  directory: ./coverage
+ token: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/coverage-linux.yml

@@ -30,7 +30,7 @@ concurrency:
  cancel-in-progress: true
 
 env:
- PYTHON_VERSION: '3.11'
+ PYTHON_VERSION: '3.12'
  FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -45,7 +45,7 @@ jobs:
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
+ uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Environment Information
@@ -68,6 +68,7 @@ jobs:
  - name: Clean tmp
  run: rm -rf coverage/tmp && rm -rf out
  - name: Upload
- uses: codecov/codecov-action@54bcd8715eee62d40e33596ef5e8f0f48dbbccab # v4.1.0
+ uses: codecov/codecov-action@c16abc29c95fcf9174b58eb7e1abf4c866893bc8 # v4.1.1
  with:
  directory: ./coverage
+ token: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/coverage-windows.yml

@@ -30,7 +30,7 @@ concurrency:
  cancel-in-progress: true
 
 env:
- PYTHON_VERSION: '3.11'
+ PYTHON_VERSION: '3.12'
  FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -45,7 +45,7 @@ jobs:
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
+ uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Install deps
@@ -67,6 +67,7 @@ jobs:
  - name: Clean tmp
  run: npx rimraf ./coverage/tmp
  - name: Upload
- uses: codecov/codecov-action@54bcd8715eee62d40e33596ef5e8f0f48dbbccab # v4.1.0
+ uses: codecov/codecov-action@c16abc29c95fcf9174b58eb7e1abf4c866893bc8 # v4.1.1
  with:
  directory: ./coverage
+ token: ${{ secrets.CODECOV_TOKEN }}