fs: add support for minimatch overrides #52789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
anonrig
reviewed
May 1, 2024
| @@ -200,6 +202,7 @@ class Glob { | |||
| optimizationLevel: 2, | |||
| platform: process.platform, | |||
| nocaseMagicOnly: true, | |||
| ...overrides, | |||
Co-authored-by: Yagiz Nizipli <[email protected]>
climba03003
reviewed
May 2, 2024
| @@ -1082,6 +1082,8 @@ added: v22.0.0 | |||
| * `cwd` {string} current working directory. **Default:** `process.cwd()` | |||
| * `exclude` {Function} Function to filter out files/directories. Return | |||
| `true` to exclude the item, `false` to include it. **Default:** `undefined`. | |||
| * `overrides` {Object} override the default `minimatch` behavior with | |||
There was a problem hiding this comment.
Opinion only, I don't think Node.js should expose API like this.
It means this API will always be tie to minimatch and will becomes a resistance on enhancement or provide node vendor-ed one.
|
If folks want to expose minimatch's API details to Node.js users, why is there |
MoLow
requested changes
May 2, 2024
|
I also am not sure this is the ask in #52779 - see #52779 (comment) |
|
I believe it more like to ask support for glob string or array in the exclude option. |
|
Yes, that sounds like a better idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional
overridesparameter to theoptionsargument offs.glob. This allows users to override the defaultminimatchglob options.Fixes #52779