lib: do not call callback if socket is closed

nodejs · May 15, 2024 · d022b6c · d022b6c
1 parent 4e9ce7c
commit d022b6c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/lib/dgram.js b/lib/dgram.js
@@ -221,7 +221,10 @@ function bindServerHandle(self, options, errCb) {
  const state = self[kStateSymbol];
  cluster._getServer(self, options, (err, handle) => {
  if (err) {
- errCb(err);
+ // Do not call callback if socket is closed
+ if (state.handle) {
+ errCb(err);
+ }
  return;
  }
 

diff --git a/test/parallel/test-dgram-bind-socket-close-before-cluster-reply.js b/test/parallel/test-dgram-bind-socket-close-before-cluster-reply.js
@@ -0,0 +1,18 @@
+'use strict';
+const common = require('../common');
+const dgram = require('dgram');
+const cluster = require('cluster');
+
+if (cluster.isPrimary) {
+ cluster.fork();
+} else {
+ // When the socket attempts to bind, it requests a handle from the cluster.
+ // Force the cluster to send back an error code.
+ const socket = dgram.createSocket('udp4');
+ cluster._getServer = function(self, options, callback) {
+ socket.close(() => { cluster.worker.disconnect(); });
+ callback(-1);
+ };
+ socket.on('error', common.mustNotCall());
+ socket.bind();
+}