fix: Patches the variable android_ndk_path #2984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g.gyp while trying to load binding.gyp' Specifying a default value for the 'android_ndk_path'' variable fixes this issue at 'termux/termux-app#3858'
|
PR was closed because my implementation was 'unethichal', but since there isn't currently a way to define those variables it is being reopened. I went through the docs at Google GYP and Node GYP |
|
A more suitable solution for the problem has been discovered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to fix 'Undefined variable android_ndk_path in binding.gyp while trying to load binding.gyp' on Termux.
Checklist
npm install && npm run lint && npm testpassesDescription of change
Specifying a default value for the 'android_ndk_path'' variable fixes this issue at 'termux/termux-app#3858'