support for long.js #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
writeLong(Long.fromValue(7))
|
@lishengguo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @gxcsoccer and @xusiyuan841028 to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
======================================
Coverage 96.1% 96.1%
======================================
Files 7 7
Lines 1079 1079
Branches 204 204
======================================
Hits 1037 1037
Misses 42 42
Continue to review full report at Codecov.
|
|
any test cases? |
|
add test case : Long.fromNumber(0) |
fengmk2
reviewed
Aug 2, 2018
| @@ -142,7 +142,7 @@ proto.writeInt = function (val) { | |||
| * ``` | |||
| */ | |||
| proto.writeLong = function (val) { | |||
| if (typeof val !== 'number' && utility.isSafeNumberString(val)) { | |||
| if (typeof val !== 'number' && utility.isSafeNumberString(val + '')) { | |||
There was a problem hiding this comment.
detect val is not equal string first.
if (typeof val !== 'number') {
if (typeof val !== 'string') {
val = val + '';
}
if (utility.isSafeNumberString(val)) {
val = Number(val);
}
}
|
Please rebase from master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writeLong(Long.fromValue(7))