Changes in Response Class contructor for status range and null body status check #1706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#1685
Changes
The validation around the input status and the validation for the null body status(204) has been added.
Additional information
npm lint
i found an pre-existing error in the@types/index.test-d.ts
file, where aResponse
instance was being constructed with no purpose, so i removed itpackage.json
as"fix:lint": "xo --fix"
so that trivial linting errors can be fixed automatically.Response.error
method, the default status code was0
but this will no longer be allowed due to to validation checks, so a new value400
will be used as default status code.