-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: flatten and merge Actions #4336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to and will mark 1 task as "Done" when merged:
This pull request has also been linked to 1 additional task:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Tests results for "E2E"14 flaky970 passed, 28 skipped Full HTML report. Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
配置操作的下拉菜单之前是多层级的,分了 enable actions 和 customize 两组,第一组是 Switch 的只能添加一次,第二组是常规的可以多次添加。但是这种设计有一些问题:
基于以上几点考虑,将配置操作的下拉菜单拍平处理,只能添加一次的操作的还保留 Switch 的效果,其他可以重复添加的操作将不再是 Switch 的交互了
主要变更
扁平化
配置操作(Configure actions)
列表以 Table 区块为例,变更前与变更后的变化如下所示:
变更前:
变更后:
此次改动对插件开发者的影响
在添加 Action 的时候不再需要 enableActions 前缀
会影响在插件中注册 Actions 时所使用的 name 的值。下面以
导入(Import)
按钮为例:在添加
导入(Import)
按钮的时候应将enableActions.import
改为import
。在添加 Action 的时候不再需要 customize 前缀
会影响在插件中注册 Actions 时所使用的 name 的值。下面以
批量编辑(Bulk edit)
为例:在添加
批量编辑(Bulk edit)
按钮的时候应将customize.bulkEdit
改为bulkEdit
。将功能相似的 Actions 合并
合并
添加(Add new)
和添加数据(Add record)
选项移除
添加数据
选项,保留添加
选项,原有的添加数据
按钮的功能转移到添加
按钮上,如下图所示,通过其它数据表(Other collections)
选项可以添加任意数据表的区块:合并
提交(Submit)
和保存记录(Save record)
选项移除
保存记录
选项,保留提交
选项,原有保存记录
按钮的配置项转移到提交
按钮上。新版提交
按钮的配置项如下所示: