Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: values to filter with emtpy values #4319

Merged
merged 5 commits into from
May 19, 2024
Merged

fix: values to filter with emtpy values #4319

merged 5 commits into from
May 19, 2024

Conversation

chareice
Copy link
Contributor

No description provided.

Copy link

height bot commented May 12, 2024

This pull request has been linked to 1 task:

  • T-4186 表单提交按钮设置保存模式为(不存在时插入,否则更新),选择日期字段,提交数据报错:{"errors":[{"message":"Cannot convert undefined or null to object"}]} (unlink task)

💡Tip: Add "Close T-4186" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

This comment has been minimized.

This comment has been minimized.

@chareice chareice merged commit 8b3b9b3 into main May 19, 2024
19 of 21 checks passed
Copy link

Tests results for "E2E"

1 failed
❌ [chromium] › plugins/@nocobase/plugin-workflow/src/client/e2e/conditionNode/continueWhenYesFormulaEngine.test.ts:113:5 › Collection event Add Data Trigger, Formula engine, determines that the trigger node single line text field variable is equal to an unequal constant, fails.

16 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-action-print/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › ReadPrettyFormActionInitializers & CalendarFormActionInitializers should add print action › print action in ReadPrettyFormActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/continueWhenYesMathEngine.test.ts:281:5 › Collection event add data trigger, Math engine, determines that the trigger node integer field variable is not equal to an unequal constant, passes.
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/BranchIntoYesAndNoFormulaEngine.test.ts:29:5 › Collection event Add Data Trigger, determines that the trigger node single line text field variable is equal to an equal constant, passes.
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/BranchIntoYesAndNoFormulaEngine.test.ts:146:5 › Collection event Add Data Trigger, determines that the trigger node single line text field variable is equal to an unequal constant, fails.
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/continueWhenYesFormulaEngine.test.ts:196:5 › Collection event Add Data Trigger, Formula engine, determines that the trigger node single line text field variable is not equal to an equal constant, fails.
⚠️ [chromium] › plugins/@nocobase/plugin-data-source-main/src/client/__e2e__/fields/manyToMany/schemaSettings2.test.ts:193:7 › form item & edit form › field component
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/form/__e2e__/form-create/lazyLoadAssociationFields.test.ts💯7 › association fields › should be possible to change the value of the association field normally
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/list/__e2e__/schemaInitializer.test.ts:29:7 › where list block can be added › popup
⚠️ [chromium] › core/client/src/modules/variable/__e2e__/basic.test.ts:14:7 › variables › linkage rules of table view action
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaSettings.test.ts:14:7 › data will be updated && Assign field values && after successful submission › data will be updated && Assign field values && after successful submission
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/association.test.ts:245:5 › association block action permission
⚠️ [chromium] › plugins/@nocobase/plugin-action-duplicate/src/client/__e2e__/schemaInitailizer.test.ts:19:7 › TableActionColumnInitializers & DetailsActionInitializers & ReadPrettyFormActionInitializers should add duplication action › duplication action in TableActionColumnInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-calendar/src/client/__e2e__/schemaInitializer.test.ts:14:7 › where can be added › page

967 passed, 28 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant