fix: previously unsurported array-style query variants #2730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a lack of standardization when it comes to encoding arrays in the query parameters, in general.
foo[0]=bar1&foo[2]=bar2
.foo[]=bar1&foo[]=bar2
foo=bar1&foo=bar2
Nock is able to handle 1 and 3 with the current code, but not 2, which is the default serialization from Axios. One could in principle just resort to a different serialization, and in fact axios support the option of serializing the parameters if any of the above approaches. However, it makes sense for Nock to support cleanly all 3 since it is being used to test APIs and for that reason it shouldn't be enforcing 1 approach over another.