Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Github Actions CI workflow #2826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Introduce Github Actions CI workflow #2826

wants to merge 3 commits into from

Conversation

Ansuel
Copy link

@Ansuel Ansuel commented Apr 28, 2024

Introduce Github Actions CI workflow to compile test Pull Request and
push.

Add simple build test on Windows, build/install/check for MacOs and
advanced test with various compile option for Ubuntu.

Signed-off-by: Christian Marangi [email protected]

…ndows

Windows doesn't provide the in_addr_t type. Replace the single
occurrence introduced by 18bedde ("Simplify building in-addr.arpa
address string") with a simple u32 that is the same exact type
internally.

Fixes: 18bedde ("Simplify building in-addr.arpa address string")
Signed-off-by: Christian Marangi <[email protected]>
@Ansuel
Copy link
Author

Ansuel commented Apr 28, 2024

@fyodor you might be interested :D

@Ansuel
Copy link
Author

Ansuel commented Apr 28, 2024

The fun thing is that alone these actions already helped and catch 2 bug/regression while implementing it...

Python 3.12 deprecated and removed the already deprecated and not
documented imp library (the load_source function was never documented)

Replace this with a modern alternative suggested by
python/cpython#104212.

Signed-off-by: Christian Marangi <[email protected]>
Introduce Github Actions CI workflow to compile test Pull Request and
push.

Add simple build test on Windows, build/install/check for MacOs and
advanced test with various compile option for Ubuntu.

Signed-off-by: Christian Marangi <[email protected]>
@Ansuel
Copy link
Author

Ansuel commented Apr 28, 2024

An example run on my local fork https://github.com/Ansuel/nmap/actions/runs/8870136052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant