Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed device_id from post requests #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IBims1NicerTobi
Copy link

Fix for new firmware versions not responding to any requests in diy mode.

@njh
Copy link
Owner

njh commented Sep 10, 2023

Thank you very much for preparing this.
I have no idea why I included the empty deviceid key in the first place.
I presume because it was either in the documentation or saw it in packet captures.

Have you been able to test this on older versions of the Sonoff firmware?

@IBims1NicerTobi
Copy link
Author

Nope this has only been tested once by me on the most recent firmware. There seems to be someone else in #18 who tried it.

@langscape
Copy link

Tested this on 3.7.6, it fixes the issue with deviceid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants