Skip to content

Commit

Permalink
github actions: better defaults
Browse files Browse the repository at this point in the history
in case someone forgets to update those
  • Loading branch information
Mic92 committed Aug 14, 2020
1 parent 7f2bf90 commit 52d63e8
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
# The repo name as used in
# https://github.com/nix-community/NUR/blob/master/repos.json
nurRepo:
- mic92
- <YOUR_REPO_NAME>
# Set this to cache your build results in cachix for faster builds
# in CI and for everyone who uses your cache.
#
Expand All @@ -27,7 +27,7 @@ jobs:
# For this to work, you also need to set the CACHIX_SIGNING_KEY secret
# in your repository settings in Github found at https://github.com/<your_githubname>/nur-packages/settings/secrets
cachixName:
-
- <YOUR_CACHIX_NAME>
nixPath:
- nixpkgs=channel:nixos-unstable
- nixpkgs=channel:nixpkgs-unstable
Expand All @@ -44,12 +44,13 @@ jobs:
run: nix-instantiate --eval -E '(import <nixpkgs> {}).lib.version'
- name: Setup cachix
uses: cachix/cachix-action@v6
if: ${{ matrix.cachixName != '' }}
if: ${{ matrix.cachixName != '<YOUR_CACHIX_NAME>' }}

This comment has been minimized.

Copy link
@06kellyjac

06kellyjac Jan 26, 2021

@Mic92
Is this meant to be != ?
Shouldn't it be ==? similar to yours https://github.com/Mic92/nur-packages/blob/master/.github/workflows/build.yml
As with the current behavior it wont enable cachix or curl the nur-update heroku app for <YOUR_CACHIX_NAME> and <YOUR_REPO_NAME> but will for others

This comment has been minimized.

Copy link
@fgaz

fgaz Jan 26, 2021

Collaborator

I think != '' was right. Could you open an issue about this?

This comment has been minimized.

Copy link
@06kellyjac

06kellyjac Jan 26, 2021

Done #38

with:
name: ${{ matrix.cachixName }}
signingKey: '${{ secrets.CACHIX_SIGNING_KEY }}'
- name: Build nix packages
# TODO switch to default nixpkgs channel once nix-build-uncached 1.0.0 is in stable
run: nix run -I 'nixpkgs=channel:nixos-unstable' nixpkgs.nix-build-uncached -c nix-build-uncached ci.nix -A cacheOutputs
- name: Trigger NUR update
if: ${{ matrix.nurRepo != '<YOUR_REPO_NAME>' }}
run: curl -XPOST "https://nur-update.herokuapp.com/update?repo=${{ matrix.nurRepo }}"

0 comments on commit 52d63e8

Please sign in to comment.