Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-line option to be intolerant of build noise. #776

Closed
wants to merge 1 commit into from

Conversation

mdempsky
Copy link
Contributor

Fixes #775.

@buildhive
Copy link

Evan Martin » ninja #806 SUCCESS
This pull request looks good
(what's this?)

@nico
Copy link
Collaborator

nico commented Jun 13, 2014

I think this is fine (thoughts on if this should interact with console pools at all? It probably won't because ninja doesn't see output from those?). It seems like a useful feature, and the implementation is simple.

(Maybe it should be part of #746, but since I don't know what to do there, waiting for it doesn't seem worth it.)

So I'll merge this, but I'm not sure if we want to use it in Chromium. But that's a discussion for a separate bug tracker :-)

@mdempsky
Copy link
Contributor Author

I only just briefly looked up what console pools are, and I'd say this feature is unrelated. But I can think on it more if you think that's worthwhile.

@nico
Copy link
Collaborator

nico commented Jun 13, 2014

Console pools are (going to be) new in 1.5. Subprocesses in a console pool inherit ninja's stdin/stdout instead of writing to a pipe and have an implicit size of 1 (so that output ordering is still well-defined). So even with -N, console pool tasks will be able to write stuff. (Which I think is fine.)

@mdempsky
Copy link
Contributor Author

Ah, I see. Yeah, agreed, it's probably fine for console pool tasks to write to stdout even if -N is passed.

@evmar
Copy link
Collaborator

evmar commented Jun 13, 2014

Since it's kind of an obscure feature, I wonder if the flag should be more verbose. (E.g. does it fit under "-d longname"? I guess not...) Sorry for not having a real proposal here, just something to consider. I wonder if Neil's proposal about rules not writing their output will need a similar flag?

@evmar
Copy link
Collaborator

evmar commented Nov 12, 2015

I think this belongs under the new -w flag. Something like -w buildnoise=err. Otherwise this is good.

@jonesmz

This comment was marked as abuse.

@jhasse
Copy link
Collaborator

jhasse commented Dec 3, 2020

Closing in favor of #480.

@jhasse jhasse closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for noise-is-failure
6 participants