Ninja status format string from argv. #1180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to set NINJA_STATUS just for a single process invocation, you can do |
|
Right. Though, it is not always launched from a shell. Addressing that use case was the original motivation of the patch. |
|
Thanks, that looks like a good feature. (Note to self: Related to #746) |
|
This comment was marked as abuse.
This comment was marked as abuse.
gkistanova
force-pushed
the
ninja-status-from-argv
branch
from
7d21510
to
d912de5
Compare
gkistanova
force-pushed
the
ninja-status-from-argv
branch
from
d912de5
to
155e7d0
Compare
|
@jonesmz The PR has been rebased on the latest master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ninja supports a status format string from NINJA_STATUS env. This is a great feature to have.
Though, in an automated build environment provisioning environmental variables could be tricky.
This patch adds a support for a command line option (--status-format=) to set the status format string. If given, the status format string from the command line would override the one from NINJA_STATUS env.
Only a long option is supported for now. Easy to add a short form if it will be a use case for that.