fix: InotifyEvent.name should be UncheckedArray[char]

[tdely]

No description provided.

[Araq]

This is not correct, see https://man7.org/linux/man-pages/man7/inotify.7.html

It is an array of unspecified size at the end of the struct, but not a pointer!

[tdely]

You're right, but cstring is working for me; it hasn't failed yet. Can the module be used in its present state with char to get the name?

[beef331]

Are you actively using the name? Cause cstring and UncheckedArray[char] have vastly different semantics. For reference https://github.com/beef331/reflector/blob/master/reflector/inotifyevents.nim are more correctly Nimified bindings for Inotify.

[tdely]

Are you actively using the name? Cause cstring and UncheckedArray[char] have vastly different semantics. For reference https://github.com/beef331/reflector/blob/master/reflector/inotifyevents.nim are more correctly Nimified bindings for Inotify.

Yes. I need the name to add watches on created files, and remove and re-add watches when files get replaced without the original being removed or moved first. I'm happy enough with the C-style bindings, but UncheckedArray[char] as you've done works just as well as cstring.. do want me to update the PR with this change?

[beef331]

It should be a UncheckedArray[char] yes, the fact cstring works for you astounds me 😄