Exclude block from endsInNoReturn, fix regression (#22632)

Co-authored-by: SirOlaf <>
nim-lang · Sep 2, 2023 · d2f36c0 · d2f36c0
1 parent bd6adbc
commit d2f36c0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/compiler/sem.nim b/compiler/sem.nim
@@ -220,7 +220,7 @@ proc endsInNoReturn(n: PNode): bool =
 
  var it = n
  # skip these beforehand, no special handling needed
- while it.kind in {nkStmtList, nkStmtListExpr, nkBlockStmt} and it.len > 0:
+ while it.kind in {nkStmtList, nkStmtListExpr} and it.len > 0:
  it = it.lastSon
 
  case it.kind

diff --git a/tests/exprs/t22604.nim b/tests/exprs/t22604.nim
@@ -10,19 +10,6 @@ for i in 0..<1:
  else:
  raiseAssert "Won't get here"
 
-# block
-for i in 0..<1:
- let x =
- case false
- of true:
- 42
- of false:
- block:
- if true:
- continue
- else:
- raiseAssert "Won't get here"
-
 # nested case
 for i in 0..<1:
  let x =