fixes bareExcept warnings; catch specific exceptions (#21119)

* fixes bareExcept warnings; catch specific exceptions * Update lib/pure/coro.nim
nim-lang · Aug 12, 2023 · 9207d77 · 9207d77
1 parent 4c89223
commit 9207d77
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/pure/asynchttpserver.nim b/lib/pure/asynchttpserver.nim
@@ -381,7 +381,7 @@ const
 proc listen*(server: AsyncHttpServer; port: Port; address = ""; domain = AF_INET) =
  ## Listen to the given port and address.
  when declared(maxDescriptors):
- server.maxFDs = try: maxDescriptors() except: nimMaxDescriptorsFallback
+ server.maxFDs = try: maxDescriptors() except OSError: nimMaxDescriptorsFallback
  else:
  server.maxFDs = nimMaxDescriptorsFallback
  server.socket = newAsyncSocket(domain)

diff --git a/lib/std/private/osdirs.nim b/lib/std/private/osdirs.nim
@@ -515,7 +515,7 @@ proc copyDirWithPermissions*(source, dest: string,
  try:
  setFilePermissions(dest, getFilePermissions(source), followSymlinks =
  false)
- except:
+ except OSError:
  if not ignorePermissionErrors:
  raise
  for kind, path in walkDir(source):

diff --git a/lib/std/private/osfiles.nim b/lib/std/private/osfiles.nim
@@ -311,7 +311,7 @@ proc copyFileWithPermissions*(source, dest: string,
  try:
  setFilePermissions(dest, getFilePermissions(source), followSymlinks =
  (cfSymlinkFollow in options))
- except:
+ except OSError:
  if not ignorePermissionErrors:
  raise
 
@@ -402,6 +402,6 @@ proc moveFile*(source, dest: string) {.rtl, extern: "nos$1",
  copyFile(source, dest, {cfSymlinkAsIs})
  try:
  removeFile(source)
- except:
+ except OSError:
  discard tryRemoveFile(dest)
  raise