make float32 literals stringifying behave in JS the same as in C (#22500

)
nim-lang · Aug 17, 2023 · 7fababd · 7fababd
1 parent 98c39e8
commit 7fababd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/compiler/jsgen.nim b/compiler/jsgen.nim
@@ -32,7 +32,7 @@ import
  ast, trees, magicsys, options,
  nversion, msgs, idents, types,
  ropes, ccgutils, wordrecg, renderer,
- cgmeth, lowerings, sighashes, modulegraphs, lineinfos, rodutils,
+ cgmeth, lowerings, sighashes, modulegraphs, lineinfos,
  transf, injectdestructors, sourcemap, astmsgs, backendpragmas
 
 import pipelineutils
@@ -43,6 +43,7 @@ import strutils except addf
 when defined(nimPreviewSlimSystem):
  import std/[assertions, syncio]
 
+import std/formatfloat
 
 type
  TJSGen = object of PPassContext
@@ -2900,7 +2901,11 @@ proc gen(p: PProc, n: PNode, r: var TCompRes) =
  r.res = rope"Infinity"
  of fcNegInf:
  r.res = rope"-Infinity"
- else: r.res = rope(f.toStrMaxPrecision)
+ else:
+ if n.typ.skipTypes(abstractVarRange).kind == tyFloat32:
+ r.res.addFloatRoundtrip(f.float32)
+ else:
+ r.res.addFloatRoundtrip(f)
  r.kind = resExpr
  of nkCallKinds:
  if isEmptyType(n.typ):

diff --git a/tests/float/tfloats.nim b/tests/float/tfloats.nim
@@ -156,9 +156,8 @@ template main =
  when nimvm:
  discard # xxx, refs #12884
  else:
- when not defined(js):
- doAssert x == 1.2345679'f32
- doAssert $x == "1.2345679"
+ doAssert x == 1.2345679'f32
+ doAssert $x == "1.2345679"
 
 static: main()
 main()